« Flash team heading to Los Angeles next week | Main | Flashteam is heads' down in work »

September 02, 2004

Why a simple fix is not always so simple : Or Why is the Find Panel Still Modal!

I was going through some old Ellipsis beta emails, and came across one that I thought could be useful to post to the Flash Team weblog. Basically, the email below is one which describes why something that seems like it would be an easy fix (in this case making the find panel non-modal), is not always as simple it seems.

Here is the email:

---------------------begin email---------------------
Subject : Why a simple fix is not always so simple : Or Why is the Find Panel Still Modal!

I wanted to write up a description of a particular issue which I think demonstrates why something that seems simple to fix / change is not always so simple. Part of the reason I am writing this is to give some context to how we decide what we can fix at this stage in the beta, but also because this was the first time I have been directly involved in the decision making process.

First, some background. At this point in Ellipsis, we are really focusing on fixing any issues caused by changes made in Ellipsis. However, the team is very committed to making this a very relevant release for users, so if there is a bug or pain point that:

1. affects a lot of users
2. does not risk / touch a lot of the code base

then we will look at it (there should be some pleasant surprises with the next beta release).

So, yesterday the issue of the Find Window being modal came up. In case you didn't read the thread, the issue is that when you open the Find Panel for the ActionScript editor, it is modal, meaning that you cannot change / edit the text in the editor while the Find Window is open. This is inconsistent with other Text Editors, and to put it frankly, is rather annoying.

So, I saw the posts about it yesterday. I thought it would be something very simple to fix (just flip a Flag on the Window so it is non-modal). Based on this, and the input from the list, we decided to look into:

1. how easy (code wise) it would be to fix the problem
2. how risky the fix would be (would it affect code that affects other parts of the app)
3. would it cause any new usability issues.

So, the issue was sent to the management team (includes product management, heads of engineering, QA and IMD(documentation)), with a suggestion that we look into this. Everyone agreed, and the head of engineering asked an engineer to look into the issue. It looked like it would be an easy fix, and an easy win for users (which is a win for us).

So, the first item that came up was actually usability related. There were concerns that it would be confusing to users if the Find Panel was open but the ActionScript editor had been closed. What should the panel do if the user clicks find then? What if they keep the panel open, but open a new frame of ActionScript? We looked at how other programs handled this (Visual Studio, EditPlus and Notepad), and determined that this would not affect many users, and that the other programs have similar issues.

So, the engineer then looked into how easy and risky it would be from a code standpoint to make the change. It turned out, that in order to make it non-modal, we couldn't just flip a Flag, but rather had to call a new method. Ok, a little more risky, but not that big of a deal.

After further investigation, we discovered that we would actually have to change the window type, which in essence would mean we would have to reprogram the Window. Again, not yet that risky, but now we are getting into more significant changes.

Finally, and the straw that broke the camels back, we found out that we would have to completely rewrite how the Find panel actually finds data. This is because currently, when you open the Find Panel, it takes a snapshot of the text in ActionScript editor (since the user won't be able to change it). I am not sure why it is done like this, but do know that it is faster than dynamically loading the text each time and keeping the cursor position each time.

Changing how the Find Panel searches text is big code change and risky. Furthermore, making the change could now lead to significant performance decreases when searching large amounts of text. These factors combined to make the change too risky for Ellipsis, and we deferred it to the next version of Flash (at which time we are basically re-writing all panel and window code).

Anyways, I just wanted to share this with the list to give some context to why something that may seem simple, doesn't get fixed for Ellipsis. This was an issue that I thought would be very simple for us to fix, but it turned out to be a lot more complicated and risky than I expected.

Again, this isn't to justify why the Find Panel is modal, but rather to give some context to how we determine what additional things we can fix at this stage.

mike chambers

mesh@macromedia.com
---------------------end email---------------------

Hope that helps put some context around how we make decisions on individual issues and requests, and show how something that seems simple can ending of being pretty complex (for any number of reasons).

Btw, the issue described above is something that we are now looking at for 8Ball.

Posted by mesh at September 2, 2004 03:06 PM

Trackback Pings

TrackBack URL for this entry:
http://weblogs.macromedia.com/mtadmin/mt-tb.cgi/1652

Listed below are links to weblogs that reference Why a simple fix is not always so simple : Or Why is the Find Panel Still Modal!:

» wyytaejwu from nauxg
nvhjgosik [Read More]

Tracked on January 5, 2005 02:31 AM

» lowest price tramadol from
ultram online prescription tramadol buy ultram online buy ultram buy tramadol [Read More]

Tracked on August 1, 2005 04:36 PM

» butalbital 100 tablets from
cheap butalbital cheap butalbital butalbital hd butalbital high side effects of butalbital [Read More]

Tracked on August 2, 2005 02:47 AM

» vicodin withdrawl from
vicodin without a prescription vicodin without a prescription vicodin drug test vicodin information vicodin online vicod... [Read More]

Tracked on August 2, 2005 02:47 AM

Comments

Mike,

This is great insight. This behaviour is obviously frustrating. I can totally understand why you wouldn't want to change it though. Every developer has at one time or another had to stand in front of their project manager and explain why something seemingly easy is, in fact, tremendously difficult and time consuming. "Trust me Dave, turning that box blue is really, really hard."

Maybe as a work around you could enable "f3" to search for a highlighted string. Currently "F3" searches for the last search string. Other text editors (SEPY, for one) have it work for the currently highlighted string. It's a great workflow improvement, IMHO.

Just a thought. Keep up the good work.

Posted by: Tim Scollick at September 2, 2004 08:51 PM

So, theses tips of changes is ridiculous, just for in case to check out as Tim Scollick said, using a simple press on your keyboard, really makes difference. I think like Mike that really frustated behavior, so where it can be arrive?.
Big changes let's a lot of time to make.
So all process need to be validated for a group of people, but at this point I just agree with Mike, this change can relly be review for the next generation of Flash.

Posted by: Igor Costa at September 2, 2004 10:37 PM

FYI, this is something we are looking at now for 8ball (since we have time to make more significant changes).

mike chambers

mesh@macromedia.com

Posted by: mike chambers at September 2, 2004 11:13 PM

Hi Mike,
Just want to tell you that this post is appreciated. Can't speak for the rest of the people but I appreciate the efforts that MM is taking to respond to the users and community. This is a good example of it.

Posted by: Ronnie at September 3, 2004 08:16 PM

why not have the find as a part of the actionscript editor... a panel or something that expands into the editor? this way closing the editor also closes the find dialogue...

Posted by: matt cram at September 13, 2004 02:06 PM

.
.
.
.
Hello? Where is the Blog?
It is very quiet here.
.
.
.
.

Posted by: Kosmo at October 4, 2004 11:28 PM

Mike
Just like to add that its been a great job by the flash team and we know you guys try your best to fix everysingle bug we asked for and we do appreciate you guys for the bugs fixed and those that will be fixed in 8Ball. Sincerely Thanks again.

Posted by: Melvyn Song at October 5, 2004 08:52 AM

Hey! Are you dead?

sylvia
http://blog.5p.org.uk

Posted by: Sylvia Anderson at January 25, 2005 04:16 AM

Know what dress colors highlight your hair, your eyes and your skin tone, and what style lines are most flattering for your body type. Buy your Prom Dresses to fit and flatter your current figure; it wouldn?t be safe to buy a smaller size if you?re still hoping to lose weight by prom night. You want a fit that skims the body with enough ease to move comfortably and gracefully.

Posted by: prom at March 16, 2005 10:28 PM

Post a comment




Remember Me?